yonlu/yellowjacket
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects Releases 13 Wiki Activity

Soulseek search: one query, no search options, and per-file durations discarded #271

New Issue
Closed
opened 2026-09-26 21:05:01 +00:00 by yonlu · 1 comment
yonlu commented 2026-09-26 21:05:01 +00:00
Owner
Copy Link
Copy Source

The Soulseek search path finds less than it could, and discards signal it already receives. Found in the same audit as #263.

  • One query, no fallback. SearchText() is Artist + " " + Album. Edition qualifiers such as "(Deluxe Edition)" or "Remastered", punctuation (Soulseek treats a term with a leading - as an exclusion), and "Various Artists" all cost results. The server also silently drops searches containing some banned terms.
  • No search options sent. The POST carries only {id, searchText}, so slskd's server-side defaults for timeout and response/file limits apply. My understanding is that these are a 15 s timeout and 100 responses, which is below our own 20 s wait; this needs verifying against the running version. maximumPeerQueueLength and minimumResponseFileCount could let slskd discard hopeless peers itself.
  • Every poll re-downloads every response. Polling uses ?includeResponses=true every second. The state alone would do, followed by one responses fetch at the end.
  • Per-file length is received and thrown away. Comparing duration against ExpectedTrack.LengthMillis is the strongest available signal for the right edition, correct alignment and truncated files.
  • freeUploadSlots appears to be a field slskd does not send.

Direction

  • A small, bounded query ladder with results merged and de-duplicated.
  • Explicit search options.
  • A state-only poll.
  • LengthMillis on CandidateFile, feeding a duration fit into the match score.
The Soulseek search path finds less than it could, and discards signal it already receives. Found in the same audit as #263. - **One query, no fallback.** `SearchText()` is `Artist + " " + Album`. Edition qualifiers such as "(Deluxe Edition)" or "Remastered", punctuation (Soulseek treats a term with a leading `-` as an exclusion), and "Various Artists" all cost results. The server also silently drops searches containing some banned terms. - **No search options sent.** The POST carries only `{id, searchText}`, so slskd's server-side defaults for timeout and response/file limits apply. My understanding is that these are a 15 s timeout and 100 responses, which is below our own 20 s wait; this needs verifying against the running version. `maximumPeerQueueLength` and `minimumResponseFileCount` could let slskd discard hopeless peers itself. - **Every poll re-downloads every response.** Polling uses `?includeResponses=true` every second. The state alone would do, followed by one responses fetch at the end. - **Per-file `length` is received and thrown away.** Comparing duration against `ExpectedTrack.LengthMillis` is the strongest available signal for the right edition, correct alignment and truncated files. - **`freeUploadSlots` appears to be a field slskd does not send.** ## Direction - A small, bounded query ladder with results merged and de-duplicated. - Explicit search options. - A state-only poll. - `LengthMillis` on `CandidateFile`, feeding a duration fit into the match score.
yonlu added the Kind/Enhancement
Priority
Medium
3
Platform/DesktopArea/Downloads labels 2026-09-26 21:05:01 +00:00
yonlu self-assigned this 2026-09-26 21:07:59 +00:00
yonlu added the
Status
In Progress
 label 2026-09-26 21:07:59 +00:00
yonlu commented 2026-09-26 21:08:00 +00:00
Author
Owner
Copy Link
Copy Source

Taking this on fix/271-slskd-search-recall, stacked on #270. Approach: explicit slskd search options, a state-only poll with one responses fetch at the end (falling back to includeResponses if that endpoint is absent), a second normalised query run alongside the first with results merged, per-file durations carried into a duration fit in the match score, and the phantom freeUploadSlots removed.

Taking this on `fix/271-slskd-search-recall`, stacked on #270. Approach: explicit slskd search options, a state-only poll with one responses fetch at the end (falling back to `includeResponses` if that endpoint is absent), a second normalised query run alongside the first with results merged, per-file durations carried into a duration fit in the match score, and the phantom `freeUploadSlots` removed.
yonlu closed this issue 2026-09-27 01:45:21 +00:00
gitea-actions bot removed the
Status
In Progress
 label 2026-09-27 01:47:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Downloads Kind/Enhancement Platform/Desktop
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#271