yonlu/yellowjacket
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects Releases 13 Wiki Activity

TestScan_StoresOnlyCoverTiers fails instead of skipping when the fixtures are not generated #266

New Issue
Closed
opened 2026-09-26 21:02:33 +00:00 by yonlu · 1 comment
yonlu commented 2026-09-26 21:02:33 +00:00
Owner
Copy Link
Copy Source

TestScan_StoresOnlyCoverTiers (backend/library/coverart_storage_test.go) builds the fixture path by hand and fails when test_data/music_library_test/ has not been generated. Every other fixture test goes through testfixtures.Load(t) and skips. In a fresh worktree the pre-push hook therefore refuses to push any branch, with read covers dir: ... no such file or directory.

Fix: take the root from testfixtures.Load(t).Root().

`TestScan_StoresOnlyCoverTiers` (`backend/library/coverart_storage_test.go`) builds the fixture path by hand and fails when `test_data/music_library_test/` has not been generated. Every other fixture test goes through `testfixtures.Load(t)` and skips. In a fresh worktree the pre-push hook therefore refuses to push any branch, with `read covers dir: ... no such file or directory`. **Fix:** take the root from `testfixtures.Load(t).Root()`.
yonlu added the
Priority
Low
4
Kind/TestingKind/Bug labels 2026-09-26 21:02:33 +00:00
yonlu self-assigned this 2026-09-26 21:02:40 +00:00
yonlu added the
Status
In Progress
 label 2026-09-26 21:02:40 +00:00
yonlu commented 2026-09-26 21:02:40 +00:00
Author
Owner
Copy Link
Copy Source

Fixing on fix/263-slskd-transfer-lifecycle as a commit of its own; it was blocking that branch's push.

Fixing on `fix/263-slskd-transfer-lifecycle` as a commit of its own; it was blocking that branch's push.
yonlu closed this issue 2026-09-27 01:45:21 +00:00
gitea-actions bot removed the
Status
In Progress
 label 2026-09-27 01:47:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Kind/Bug Kind/Testing
Priority
Low
4
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#266