yonlu/yellowjacket
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects Releases 13 Wiki Activity

Build: require Go 1.26 everywhere at once #265

New Issue
Closed
opened 2026-09-26 20:59:47 +00:00 by yonlu · 1 comment
yonlu commented 2026-09-26 20:59:47 +00:00
Owner
Copy Link
Copy Source

go.mod declares go 1.25.0, and CI, the desktop and APK workflows, the Arch makedepends and CONTRIBUTING all say 1.25. Two things push toward 1.26:

  • The newest github.com/go-json-experiment/json (indirect, via wails/v3/pkg/application) declares go 1.26, so upgrading it raises our go directive with it.
  • Locally, make lint under Go 1.27 panics inside honnef.co/go/tools@v0.7.0 (buildir: unexpected expr: *ast.KeyValueExpr), and this reproduces on a clean main. Linting needs GOTOOLCHAIN=go1.26.0 either way.

Direction

Require Go 1.26 in one step, everywhere at once: go.mod/go.sum, GO_VERSION in ci.yml, desktop-assets.yml and android-apk.yml, makedepends in the PKGBUILD, and the table in CONTRIBUTING.

The Homebrew formula builds from source on the user's machine, so its Go dependency needs the same check.

`go.mod` declares `go 1.25.0`, and CI, the desktop and APK workflows, the Arch `makedepends` and CONTRIBUTING all say 1.25. Two things push toward 1.26: - The newest `github.com/go-json-experiment/json` (indirect, via `wails/v3/pkg/application`) declares `go 1.26`, so upgrading it raises our `go` directive with it. - Locally, `make lint` under Go 1.27 panics inside `honnef.co/go/tools@v0.7.0` (`buildir: unexpected expr: *ast.KeyValueExpr`), and this reproduces on a clean `main`. Linting needs `GOTOOLCHAIN=go1.26.0` either way. ## Direction Require Go 1.26 in one step, everywhere at once: `go.mod`/`go.sum`, `GO_VERSION` in `ci.yml`, `desktop-assets.yml` and `android-apk.yml`, `makedepends` in the PKGBUILD, and the table in CONTRIBUTING. The Homebrew formula builds from source on the user's machine, so its Go dependency needs the same check.
yonlu added the Kind/EnhancementArea/Packaging
Priority
Low
4
 labels 2026-09-26 20:59:47 +00:00
yonlu self-assigned this 2026-09-26 21:00:55 +00:00
yonlu added the
Status
In Progress
 label 2026-09-26 21:00:56 +00:00
yonlu commented 2026-09-26 21:00:56 +00:00
Author
Owner
Copy Link
Copy Source

Taking this on build/265-go-1.26, as one commit that moves every Go version pin at once, including index-artifact.yml's golang:1.25 image, which the local bump had missed.

Taking this on `build/265-go-1.26`, as one commit that moves every Go version pin at once, including `index-artifact.yml`'s `golang:1.25` image, which the local bump had missed.
yonlu closed this issue 2026-09-27 01:45:21 +00:00
gitea-actions bot removed the
Status
In Progress
 label 2026-09-27 01:46:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Design
Area/Downloads
Area/Explore
Area/Library-UI
Area/Metadata
Area/Packaging
Area/Player
Area/Queue
Area/Settings
Area/Shell-Nav
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Platform/Android
Platform/Desktop
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
In Progress
Somebody is actively working on this right now
No labels Area/Packaging Kind/Enhancement
Priority
Low
4
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan yonlu
No Assignees yonlu
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: yonlu/yellowjacket#265