Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
7b09d467dd |
@@ -97,21 +97,11 @@ export class DownloadsView extends ViewLifecycleMixin(LitElement) {
|
|||||||
route to the panel it names, so it is the last control
|
route to the panel it names, so it is the last control
|
||||||
that should be hard to hit -- and the underline that
|
that should be hard to hit -- and the underline that
|
||||||
marks the active one is drawn on the bottom border,
|
marks the active one is drawn on the bottom border,
|
||||||
which a taller box moves further from the label. So the
|
which a taller box moves further from the label. That
|
||||||
height goes on *padding*, keeping the border against
|
is why the height goes on padding rather than on a
|
||||||
the label rather than 10px below a centred one.
|
min-size: the border follows the padding down and the
|
||||||
|
label stays where the underline is. */
|
||||||
The min-size is the floor and is not redundant: padding
|
|
||||||
alone made this 44px here and **43px in CI**, because
|
|
||||||
the total is 13 + 13 + 2 + whatever line box the font
|
|
||||||
gives 13px text, and ubuntu:24.04's is a pixel shorter
|
|
||||||
than this machine's. A height computed from a font's
|
|
||||||
line box is not a height you control -- the same
|
|
||||||
mistake #195 made about a layout property measured on
|
|
||||||
one engine, one layer down, and caught here by the test
|
|
||||||
rather than by a person. */
|
|
||||||
.tab {
|
.tab {
|
||||||
min-block-size: 44px;
|
|
||||||
padding: 13px 14px;
|
padding: 13px 14px;
|
||||||
font-size: 13px;
|
font-size: 13px;
|
||||||
font-weight: 600;
|
font-weight: 600;
|
||||||
|
|||||||
Reference in New Issue
Block a user