style(19-02): fix wsl lint warnings in WAV test and writer
- Add blank lines before cuddled expressions in wav_test.go - Fix cuddled copy expression in wav.go writeRIFF - All WAV lint issues resolved (remaining are pre-existing in other files)
This commit is contained in:
@@ -169,6 +169,7 @@ func writeRIFF(w io.Writer, chunks []riffChunk, id3Data []byte) error {
|
|||||||
|
|
||||||
// Write id3 chunk last.
|
// Write id3 chunk last.
|
||||||
var id3ID [4]byte
|
var id3ID [4]byte
|
||||||
|
|
||||||
copy(id3ID[:], "id3 ")
|
copy(id3ID[:], "id3 ")
|
||||||
|
|
||||||
return writeChunk(w, id3ID, id3Data)
|
return writeChunk(w, id3ID, id3Data)
|
||||||
|
|||||||
@@ -76,6 +76,7 @@ func createTestWAV(
|
|||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&buf, binary.LittleEndian, uint32(len(fmtData)),
|
&buf, binary.LittleEndian, uint32(len(fmtData)),
|
||||||
)
|
)
|
||||||
|
|
||||||
buf.Write(fmtData)
|
buf.Write(fmtData)
|
||||||
|
|
||||||
// data chunk.
|
// data chunk.
|
||||||
@@ -83,6 +84,7 @@ func createTestWAV(
|
|||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&buf, binary.LittleEndian, uint32(silenceLen),
|
&buf, binary.LittleEndian, uint32(silenceLen),
|
||||||
)
|
)
|
||||||
|
|
||||||
buf.Write(silence)
|
buf.Write(silence)
|
||||||
|
|
||||||
// id3 chunk (if any).
|
// id3 chunk (if any).
|
||||||
@@ -91,6 +93,7 @@ func createTestWAV(
|
|||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&buf, binary.LittleEndian, uint32(len(id3Bytes)),
|
&buf, binary.LittleEndian, uint32(len(id3Bytes)),
|
||||||
)
|
)
|
||||||
|
|
||||||
buf.Write(id3Bytes)
|
buf.Write(id3Bytes)
|
||||||
|
|
||||||
if len(id3Bytes)%2 != 0 {
|
if len(id3Bytes)%2 != 0 {
|
||||||
@@ -314,6 +317,7 @@ func TestWriteWavTags_ChunkPreservation(t *testing.T) {
|
|||||||
|
|
||||||
// Count non-id3 chunks in both.
|
// Count non-id3 chunks in both.
|
||||||
origNonID3 := 0
|
origNonID3 := 0
|
||||||
|
|
||||||
for _, c := range origChunks {
|
for _, c := range origChunks {
|
||||||
if !isID3ChunkID(c.id) {
|
if !isID3ChunkID(c.id) {
|
||||||
origNonID3++
|
origNonID3++
|
||||||
@@ -321,6 +325,7 @@ func TestWriteWavTags_ChunkPreservation(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
newNonID3 := 0
|
newNonID3 := 0
|
||||||
|
|
||||||
for _, c := range newChunks {
|
for _, c := range newChunks {
|
||||||
if !isID3ChunkID(c.id) {
|
if !isID3ChunkID(c.id) {
|
||||||
newNonID3++
|
newNonID3++
|
||||||
@@ -576,10 +581,12 @@ func createTestWAVWithExtraChunks(
|
|||||||
|
|
||||||
// INAM sub-chunk.
|
// INAM sub-chunk.
|
||||||
inamValue := []byte("Test Track Name")
|
inamValue := []byte("Test Track Name")
|
||||||
|
|
||||||
listBuf.WriteString("INAM")
|
listBuf.WriteString("INAM")
|
||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&listBuf, binary.LittleEndian, uint32(len(inamValue)),
|
&listBuf, binary.LittleEndian, uint32(len(inamValue)),
|
||||||
)
|
)
|
||||||
|
|
||||||
listBuf.Write(inamValue)
|
listBuf.Write(inamValue)
|
||||||
|
|
||||||
// Pad INAM if odd length.
|
// Pad INAM if odd length.
|
||||||
@@ -621,6 +628,7 @@ func createTestWAVWithExtraChunks(
|
|||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&buf, binary.LittleEndian, uint32(len(fmtData)),
|
&buf, binary.LittleEndian, uint32(len(fmtData)),
|
||||||
)
|
)
|
||||||
|
|
||||||
buf.Write(fmtData)
|
buf.Write(fmtData)
|
||||||
|
|
||||||
// LIST chunk.
|
// LIST chunk.
|
||||||
@@ -628,6 +636,7 @@ func createTestWAVWithExtraChunks(
|
|||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&buf, binary.LittleEndian, uint32(len(listData)),
|
&buf, binary.LittleEndian, uint32(len(listData)),
|
||||||
)
|
)
|
||||||
|
|
||||||
buf.Write(listData)
|
buf.Write(listData)
|
||||||
|
|
||||||
// bext chunk.
|
// bext chunk.
|
||||||
@@ -635,6 +644,7 @@ func createTestWAVWithExtraChunks(
|
|||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&buf, binary.LittleEndian, uint32(len(bextData)),
|
&buf, binary.LittleEndian, uint32(len(bextData)),
|
||||||
)
|
)
|
||||||
|
|
||||||
buf.Write(bextData)
|
buf.Write(bextData)
|
||||||
|
|
||||||
// data chunk.
|
// data chunk.
|
||||||
@@ -642,6 +652,7 @@ func createTestWAVWithExtraChunks(
|
|||||||
_ = binary.Write(
|
_ = binary.Write(
|
||||||
&buf, binary.LittleEndian, uint32(silenceLen),
|
&buf, binary.LittleEndian, uint32(silenceLen),
|
||||||
)
|
)
|
||||||
|
|
||||||
buf.Write(silence)
|
buf.Write(silence)
|
||||||
|
|
||||||
path := filepath.Join(dir, name)
|
path := filepath.Join(dir, name)
|
||||||
|
|||||||
Reference in New Issue
Block a user