From cee19d7ef936dd8a9a4dfa0cd1afc1e1801f07fa Mon Sep 17 00:00:00 2001
From: Logan <logan@ljones.me>
Date: Wed, 12 Aug 2026 01:47:46 -0400
Subject: [PATCH] fix(settings): let a library be renamed by clicking its name

The name's click bubbled to config-page's own document handler, which
exists to close the rename editor - so it opened and closed the editor
in the same click and the field never appeared. The overflow menu's
Rename was unaffected because it stops propagation, which is why the
feature looked like it worked.

Found while closing Phase 3 and left for the phase that reworks this
file. The e2e guard opens the editor and abandons it rather than
committing a rename: the specs share one backend process, and a
renamed library fails the ones that assert on fixture content.
---
 e2e/specs/library.spec.ts                     | 58 +++++++++++++++++++
 .../src/components/config-page/config-page.ts |  8 ++-
 2 files changed, 65 insertions(+), 1 deletion(-)

diff --git a/e2e/specs/library.spec.ts b/e2e/specs/library.spec.ts
index 495ceb6..55ce75f 100644
--- a/e2e/specs/library.spec.ts
+++ b/e2e/specs/library.spec.ts
@@ -65,4 +65,62 @@ test.describe('library views', () => {
     await expect(app.getByText('Aurora Fields').first()).toBeVisible();
     await expect(app.getByText('Pale Circuit').first()).toBeVisible();
   });
+
+  test('a library can be renamed from its own name', async ({ app }) => {
+    // Found while closing Phase 3: clicking the name opened the rename
+    // editor and closed it in the same click, because the click bubbled
+    // to config-page's own document handler — which exists to close it.
+    // The overflow menu's Rename always worked; it stops propagation.
+    //
+    // The editor is opened and abandoned, never committed: these specs
+    // share one backend process, and a renamed library would fail the
+    // ones after this on fixture content.
+    await app.getByTestId('nav-settings').click();
+    await expect(app.getByTestId('main-content')).toHaveAttribute(
+      'data-active-view',
+      'settings',
+    );
+
+    const page = app.locator('config-page');
+
+    await expect
+      .poll(() =>
+        page.evaluate((el) => {
+          const sections = [
+            ...(el.shadowRoot?.querySelectorAll('config-section') ?? []),
+          ];
+          const libraries = sections.at(-1);
+          const header =
+            libraries?.shadowRoot?.querySelector<HTMLElement>('.header');
+
+          header?.click();
+
+          return !!el.shadowRoot?.querySelector('.library-name');
+        }),
+      )
+      .toBe(true);
+
+    const opened = await page.evaluate(async (el) => {
+      el.shadowRoot
+        ?.querySelector<HTMLElement>('.library-name')
+        ?.click();
+
+      // Lit renders on a microtask: a synchronous read here reports
+      // "not editing" on a build where it works, which is how this bug
+      // was first "reproduced" against a fix that already worked.
+      await new Promise((r) => setTimeout(r, 100));
+
+      return !!el.shadowRoot?.querySelector('.edit-input');
+    });
+
+    expect(opened).toBe(true);
+
+    // Escape the editor without renaming, and leave the app on Tracks.
+    await app.keyboard.press('Escape');
+    await app.getByTestId('nav-tracks').click();
+    await expect(app.getByTestId('main-content')).toHaveAttribute(
+      'data-active-view',
+      'tracks',
+    );
+  });
 });
diff --git a/frontend/src/components/config-page/config-page.ts b/frontend/src/components/config-page/config-page.ts
index 3412084..ac4cbdf 100644
--- a/frontend/src/components/config-page/config-page.ts
+++ b/frontend/src/components/config-page/config-page.ts
@@ -2096,7 +2096,13 @@ export class ConfigPage extends ViewLifecycleMixin(LitElement) {
                                             : html`
                                                   <span
                                                       class="library-name"
-                                                      @click=${() => this.handleStartRename(lib.id, lib.name)}
+                                                      @click=${(e: Event) => {
+                                                          // The document handler closes the
+                                                          // editor, and without this it closes
+                                                          // the one this very click opened.
+                                                          e.stopPropagation();
+                                                          this.handleStartRename(lib.id, lib.name);
+                                                      }}
                                                   >
                                                       ${lib.name}
                                                   </span>