test: cover jobs in Settings, and unpick two shared selectors

The spec worth having is not that the tab is gone -- that is one line
of a table -- but that nothing became unreachable when it went. #24
promises that no action is ever unreachable at any supported size, and
deleting a destination is exactly the change that quietly breaks it.

Two existing selectors had to give. `config-section .header` is
ambiguous the moment a section holds a job, because `job-details-drawer`
carries that class too -- so `settings-reach.spec.ts` locates a
disclosure by role and name instead. And `page-header`'s and
`offline-icons`'s view lists lose an entry each.

Closes #27
This commit is contained in:
2026-08-19 20:27:48 -04:00
parent 8efed2dd2b
commit c79d4d47a3
10 changed files with 141 additions and 20 deletions
@@ -72,7 +72,6 @@ const ALL_VISIBLE = {
explore: true,
downloads: true,
autotag: true,
jobs: true,
settings: true,
};
@@ -96,7 +95,6 @@ describe('view visibility', () => {
'explore',
'downloads',
'autotag',
'jobs',
'settings',
]);
});
@@ -104,11 +102,11 @@ describe('view visibility', () => {
it('drops the ones the user switched off', async () => {
const el = await fixture<LitElement>('app-sidebar');
await setViews({ ...ALL_VISIBLE, autotag: false, jobs: false });
await setViews({ ...ALL_VISIBLE, autotag: false, explore: false });
await el.updateComplete;
expect(navIDs(el)).not.toContain('autotag');
expect(navIDs(el)).not.toContain('jobs');
expect(navIDs(el)).not.toContain('explore');
expect(navIDs(el)).toContain('settings');
});