yonlu/yellowjacket
1
1
Fork 0
Code Issues 52 Pull Requests 4 Actions Packages Projects Releases 12 Wiki Activity

feat(explore): say whether a page is the catalog or your own copy

Browse Source 
The album and artist pages draw from two sources and rendered
identically either way. An album showing one track because that is all
you own was indistinguishable from an album that has one track, and
both were indistinguishable from a page still waiting on a background
catalog fetch — so the answer to "is more coming?" was to keep
reloading and find out.

<catalog-scope-notice> names the source in one line: silent for full
catalog data, "still loading" while a fetch may land, "library only"
for an entity with no MBID (which will never fill in, so it points at
Autotag), and a retryable notice when the catalog had nothing to say.

Both pages needed a new distinction to drive it. loadingReleases and
its artist-side equivalents mean "something is renderable", which a
library stand-in satisfies — so catalogPending/catalogLoaded track the
different question of whether the catalog has actually answered.

Also fixes the artist page clobbering its library-hydrated discography
with an empty catalog result. An empty BrowseReleaseGroups means the
index has not built this artist yet, not that they released nothing.
This commit is contained in:
logan
2026-08-11 01:15:11 -04:00
parent 7c3c0e25b9
commit ba35858208
4 changed files with 351 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/explore-artist-details/explore-artist-details.ts
+57 -1
View File
@@ -32,6 +32,8 @@ import { EventsOn } from '@runtime/runtime';
import { Events } from '../../events';
import '@awesome.me/webawesome/dist/components/icon/icon.js';
import '../library-status-indicator/library-status-indicator.js';
import '../catalog-scope-notice/catalog-scope-notice.js';
import type { CatalogScope } from '../catalog-scope-notice/catalog-scope-notice.js';
/* ── Constants ── */
@@ -103,6 +105,12 @@ export class ExploreArtistDetails extends LitElement {
@state() private loadingReleases = true;
@state() private errorArtist = '';
@state() private errorReleases = '';
/** True once the discography on screen came from the catalog rather
* than standing in from the local library. */
@state() private catalogLoaded = false;
/** True while a catalog fetch — foreground or the background
* discography build — may still land. */
@state() private catalogPending = false;
@state() private similarArtists: LBSimilarArtist[] = [];
@state() private loadingSimilar = true;
@state() private artistImageURL = '';
@@ -920,6 +928,7 @@ export class ExploreArtistDetails extends LitElement {
this.discogReloaded.add(mbid);
this.similarReloaded.add(mbid);
this.catalogPending = false;
if (this.topTracks.length === 0) this.loadingTracks = false;
if (this.topReleaseGroups.length === 0) this.loadingTopReleases = false;
if (this.releaseGroups.length === 0) this.loadingReleases = false;
@@ -1037,6 +1046,8 @@ export class ExploreArtistDetails extends LitElement {
// forever if ArtistDiscographyReady never arrives.
this.discogReloaded.delete(mbid);
this.similarReloaded.delete(mbid);
this.catalogLoaded = false;
this.catalogPending = true;
this.armDiscogFallback(mbid);
// Phase 1: fire all API requests independently so the UI
@@ -1246,6 +1257,35 @@ export class ExploreArtistDetails extends LitElement {
}
}
/**
* Where this page's discography came from. An artist with no MBID
* can only ever show what the library holds; one whose catalog
* fetch is still in flight says so rather than looking finished.
*/
private catalogScope(): CatalogScope {
if (!this.artistMBID) return 'library';
if (this.catalogLoaded) return 'catalog';
if (this.catalogPending) return 'loading';
return 'unavailable';
}
/** Ask the catalog again after a failed or empty discography fetch. */
private retryCatalog = () => {
const mbid = this.artistMBID;
if (!mbid) return;
this.errorReleases = '';
this.catalogPending = true;
this.discogReloaded.delete(mbid);
this.similarReloaded.delete(mbid);
this.armDiscogFallback(mbid);
void this.fetchTopTracks(mbid);
void this.fetchTopReleaseGroups(mbid);
void this.fetchReleaseGroups(mbid);
void this.fetchSimilarArtists(mbid);
};
private async fetchArtist(mbid: string) {
try {
this.artist = await LookupArtist(mbid);
@@ -1396,7 +1436,17 @@ export class ExploreArtistDetails extends LitElement {
private async fetchReleaseGroups(mbid: string) {
try {
const rgs = await BrowseReleaseGroups(mbid);
this.releaseGroups = rgs ?? [];
// An empty result is "the index has not built this artist
// yet", not "this artist released nothing" — so it must not
// wipe the library albums hydrateFromCache put on screen.
if (rgs && rgs.length > 0) {
this.releaseGroups = rgs;
this.catalogLoaded = true;
this.catalogPending = false;
} else if (this.discogReloaded.has(mbid)) {
this.catalogPending = false;
}
// Populate libraryMBIDs from the inLibrary flag (already
// set by the backend via local_release_group_id cross-ref).
@@ -1414,6 +1464,7 @@ export class ExploreArtistDetails extends LitElement {
} catch (err) {
const msg = err instanceof Error ? err.message : String(err);
this.errorReleases = msg;
this.catalogPending = false;
console.error(
`[explore-artist] BrowseReleaseGroups error: ${msg}`,
);
@@ -1889,6 +1940,11 @@ export class ExploreArtistDetails extends LitElement {
</div>
</div>
<div class="content">
<catalog-scope-notice
scope=${this.catalogScope()}
entity-type="artist"
@catalog-retry=${this.retryCatalog}
></catalog-scope-notice>
${this.renderTopSection()} ${this.renderDiscography()}
${this.renderSimilarArtists()}
</div>