From 894b16d2f7d95db23b1286e72827ba59cd3a0452 Mon Sep 17 00:00:00 2001 From: Logan Date: Fri, 21 Aug 2026 10:37:49 -0400 Subject: [PATCH] docs(player): attribute the phone seek bar's removal correctly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The paragraph said #59 took the seek bar off the phone's transport. It was plan 016 B2 — audio-player.ts says so in the comment above the rule that does it, and CLAUDE.md's own #59 paragraph says #59 removed shuffle, repeat and the queue button. Wrong provenance in the file whose whole value is being right about which change did what. Also stop tracking .pi/journal.md. It is a scheduled run's scratch log, and this repo's memory is CLAUDE.md and .planning/ — a session log arriving inside a feature PR is a new convention landing sideways. --- .gitignore | 5 +++ .pi/journal.md | 38 ------------------- CLAUDE.md | 4 +- .../progress-line/progress-line.ts | 4 +- 4 files changed, 9 insertions(+), 42 deletions(-) delete mode 100644 .pi/journal.md diff --git a/.gitignore b/.gitignore index 3b3893d..91840b5 100644 --- a/.gitignore +++ b/.gitignore @@ -88,3 +88,8 @@ build/android/overlay.json # Written by @semantic-release/changelog purely to carry the release notes # into scripts/gitea-release.sh; the release page is the changelog. .release-notes.md + +# Agent session log: local scratch, not repo memory (that is CLAUDE.md +# and .planning/). Written by the scheduled backlog runs. +.pi/journal.md +.pi/schedule-prompts.json diff --git a/.pi/journal.md b/.pi/journal.md deleted file mode 100644 index abb32a0..0000000 --- a/.pi/journal.md +++ /dev/null @@ -1,38 +0,0 @@ -# Journal - -Running work log: what was done, what was verified, what was left open. -Newest entry last. - -## 2026-08-21 — #58, the phone's progress line - -Took #58 (Phase 3, item 4 of the roadmap in #73; #56 and #59 landed -before it and #64 after, so this was the phase's remaining item ahead of -#51's verification pass). Branch `feat/58-mini-player-progress-line`. - -**What.** `` in the shell, with its own `auto` -grid row between `bottom-bar` and `bottom-nav` below 600px. 2px, the -fill is `scaleX()` off `PlaybackPositionChanged` with the seek bar's -`trackChangeId`/`seq` guards and an interval that only interpolates -between reports. `aria-hidden`, `pointer-events: none`, and it renders -nothing above 600px or with no track. - -**Verified.** - -- `make ui-test` — 992 passed, including 8 new in - `frontend/test/components/progress-line.test.ts` (the matchMedia - branch, the report/interpolation rules, paused, a stale report, and - that it is neither announced nor touchable). -- `make e2e --project=chromium` — 223 passed, including 3 new in - `e2e/specs/phone-progress-line.spec.ts` (the two adjacencies, that it - takes no taps, that it is absent on a desktop). WebKit is CI's half; - Arch cannot run Playwright's Linux WebKit. -- Read a screenshot at the reference device's 424x439 with a real track - playing, and watched the real transform advance 0.288889 -> 0.377778 - over 8 s of a 90 s track. Also checked the line goes with the bar on - `now-playing`. -- No Go changed, so `make lint`/`make test` were not run. - -**Left open.** No device tier: this is a browser at 424x439, which -`CLAUDE.md` is explicit is not a phone. The line's *appearance* on -Chrome 113 is unverified; the CSS it uses (a transform and a flat -background) is nowhere near that engine's gaps. diff --git a/CLAUDE.md b/CLAUDE.md index a9e5735..dd5ab08 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -1910,8 +1910,8 @@ asserted as `'33x21'` rather than as a range, because the regression was three pixels. **What that bar lost is how far through the song it is, and -`` is where it went** (#58). #59 took the seek -bar off the phone's transport, so the one thing a mini player is +`` is where it went** (#58). Plan 016 B2 took the +seek bar off the phone's transport, so the one thing a mini player is expected to say without being opened had nowhere left to be said. It is a 2px line on the border between the mini player and the tab bar: the **shell's** element and its own `auto` grid row between `bottom-bar` diff --git a/frontend/src/components/audio-player/progress-line/progress-line.ts b/frontend/src/components/audio-player/progress-line/progress-line.ts index 0aa8c8c..953d70e 100644 --- a/frontend/src/components/audio-player/progress-line/progress-line.ts +++ b/frontend/src/components/audio-player/progress-line/progress-line.ts @@ -9,8 +9,8 @@ import { PHONE_QUERY } from '../../../utils/breakpoints'; * How far through the song we are, on the border between the mini * player and the tab bar (#58). * - * The phone's bottom bar carries three controls and no seek bar — #59 - * took it out, because 4px of height is not a thumb target and the + * The phone's bottom bar carries three controls and no seek bar — plan + * 016 B2 took it out, because 4px of height is not a thumb target and the * full-screen `now-playing-view` is where seeking belongs. What went * with it is the one thing a mini player is expected to say without * being opened: how far through the song it is. This is that, and