From 7317e093a7f92651ab65b2f83381d02105bdc0df Mon Sep 17 00:00:00 2001
From: Logan <logan@ljones.me>
Date: Fri, 13 Feb 2026 22:18:21 -0600
Subject: [PATCH] fix(ci): fix golangci-lint version, skip player test in CI,
 remove standalone frontend build

- Use specific golangci-lint version (v2.5.0) instead of 'v2' which
  the action cannot parse
- Use --build-tags flag (v2 syntax) instead of -tags
- Skip player test in CI: requires Wails runtime context and audio
  device which are unavailable in GitHub Actions
- Remove standalone 'pnpm build' from frontend job since Vite cannot
  resolve Wails path aliases alone; the build-check job validates the
  full build via Wails
---
 .github/workflows/ci.yml      | 13 ++++++-------
 backend/player/player_test.go |  7 +++++++
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6ec7806..61ecc3b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -75,8 +75,8 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v7
         with:
-          version: v2
-          args: --timeout 5m -tags webkit2_41
+          version: v2.5.0
+          args: --timeout 5m --build-tags webkit2_41
 
       - name: govulncheck
         uses: golang/govulncheck-action@v1
@@ -137,10 +137,12 @@ jobs:
           echo "Generated code is up to date."
 
   # ──────────────────────────────────────────────
-  # Frontend: type-check and build
+  # Frontend: type-check
+  # (full build is verified by the build-check job
+  #  via Wails which handles path resolution)
   # ──────────────────────────────────────────────
   frontend:
-    name: Frontend Build
+    name: Frontend Type Check
     runs-on: ubuntu-latest
     defaults:
       run:
@@ -164,9 +166,6 @@ jobs:
       - name: Type check
         run: pnpm exec tsc --noEmit
 
-      - name: Build
-        run: pnpm build
-
   # ──────────────────────────────────────────────
   # Build verification: ensure it compiles on all
   # target platforms (no artifacts uploaded)
diff --git a/backend/player/player_test.go b/backend/player/player_test.go
index 41de230..7716c71 100644
--- a/backend/player/player_test.go
+++ b/backend/player/player_test.go
@@ -3,6 +3,7 @@ package player
 import (
 	"context"
 	"log/slog"
+	"os"
 	"testing"
 )
 
@@ -13,6 +14,12 @@ var testQueue = []string{
 }
 
 func TestPlayer(t *testing.T) {
+	// This test requires a Wails runtime context for event registration and
+	// an audio device for playback. Skip in CI where neither is available.
+	if os.Getenv("CI") != "" {
+		t.Skip("skipping: requires Wails runtime context and audio device")
+	}
+
 	t.Logf("Starting test")
 
 	p, err := NewPlayer(context.Background(), slog.Default(), nil)