diff --git a/frontend/src/components/config-page/config-field.ts b/frontend/src/components/config-page/config-field.ts
index 032c784..5bbd352 100644
--- a/frontend/src/components/config-page/config-field.ts
+++ b/frontend/src/components/config-page/config-field.ts
@@ -85,6 +85,21 @@ export class ConfigField extends LitElement {
gap: 0.5em;
}
+ /* Every control here meets the app's 44px touch floor (#186).
+
+ This is the shape every row in Settings uses, so it is the
+ one rule that covers the most controls -- and it is the
+ *cheapest* place to reach the floor, because there is no
+ overflow fit on this page. The page header's had one (#69),
+ which is why that pass had to grow padding and hand the
+ width back with a negative margin; here the control is a
+ block in a column and a taller box costs nothing but the
+ height it takes.
+
+ Measured on the reference device before this: the select
+ 335x30, the text and number inputs the same, the browse
+ button 30 tall, the colour swatch 33x33 and the toggle
+ **34x19**. */
input[type='text'],
input[type='number'] {
background: var(--yj-bg-elevated, #343a40);
@@ -95,6 +110,7 @@ export class ConfigField extends LitElement {
font-size: 0.85em;
font-family: inherit;
min-width: 0;
+ min-block-size: 44px;
flex: 1;
}
@@ -117,6 +133,7 @@ export class ConfigField extends LitElement {
font-size: 0.85em;
font-family: inherit;
cursor: pointer;
+ min-block-size: 44px;
flex: 1;
}
@@ -139,6 +156,7 @@ export class ConfigField extends LitElement {
font-size: 0.85em;
cursor: pointer;
white-space: nowrap;
+ min-block-size: 44px;
}
button:hover {
@@ -158,8 +176,12 @@ export class ConfigField extends LitElement {
}
input[type='color'] {
- width: 2.5em;
- height: 2.5em;
+ /* border-box, or the 2px border makes this 48 and the
+ assertion below reads as passing by four pixels of
+ border rather than by the rule. */
+ box-sizing: border-box;
+ width: 44px;
+ height: 44px;
border: 2px solid var(--yj-border, #444);
border-radius: 4px;
padding: 0;
@@ -187,12 +209,32 @@ export class ConfigField extends LitElement {
display: flex;
align-items: center;
justify-content: space-between;
+ min-block-size: 44px;
}
+ /* The toggle is the one control here whose target and paint
+ must differ, and it is also the one no sweep can see.
+
+ Its is opacity: 0; width: 0; height: 0, so a
+ walk of every input on the page skips it as a zero-sized
+ node -- the thing a finger actually hits is this
diff --git a/frontend/src/components/config-page/download-clients.ts b/frontend/src/components/config-page/download-clients.ts
index 6aef7a3..d1bceb8 100644
--- a/frontend/src/components/config-page/download-clients.ts
+++ b/frontend/src/components/config-page/download-clients.ts
@@ -8,6 +8,7 @@ import '@awesome.me/webawesome/dist/components/switch/switch.js';
import '@awesome.me/webawesome/dist/components/spinner/spinner.js';
import '@awesome.me/webawesome/dist/components/callout/callout.js';
import { designTokens } from '../../styles/tokens.css';
+import { waTouchFloor } from '../../styles/wa-touch-floor.css';
import type {
DownloadDescriptor,
DownloadProvider,
@@ -136,6 +137,7 @@ export class DownloadClients extends LitElement {
static override styles = [
designTokens,
+ waTouchFloor,
css`
:host {
display: block;
@@ -239,12 +241,17 @@ export class DownloadClients extends LitElement {
margin-top: 0.4em;
}
+ /* The checkbox is 16x16 and cannot grow without becoming
+ a 44px checkbox, but it is already wrapped in the label
+ that names it -- so the label is the target and only
+ needs the height (#186). Eight of them. */
.format-option {
display: flex;
align-items: center;
gap: 0.4em;
font-size: 0.9em;
cursor: pointer;
+ min-block-size: 44px;
}
`,
];
diff --git a/frontend/src/components/config-page/shortcut-capture.ts b/frontend/src/components/config-page/shortcut-capture.ts
index 96774fe..b072fd9 100644
--- a/frontend/src/components/config-page/shortcut-capture.ts
+++ b/frontend/src/components/config-page/shortcut-capture.ts
@@ -25,6 +25,11 @@ export class ShortcutCapture extends LitElement {
:host {
display: inline-block;
}
+ /* 80x25, twenty-six of them -- the most numerous control on
+ the Settings page after the column lists (#186). The floor
+ is a height here and nothing else: the width was already
+ past it, and the type stays where it is so a shortcut still
+ reads as a key rather than as a button. */
button {
font-family: inherit;
font-size: var(--yj-text-sm, 13px);
@@ -35,6 +40,7 @@ export class ShortcutCapture extends LitElement {
color: var(--yj-text-primary, #eee);
cursor: pointer;
min-width: 80px;
+ min-height: 44px;
text-align: center;
transition:
border-color 0.15s,
@@ -61,6 +67,11 @@ export class ShortcutCapture extends LitElement {
opacity: 0.7;
}
}
+ /* Reset renders only for a rebound shortcut, so a sweep of a
+ freshly-installed app never sees it -- it is not in #186's
+ tables for that reason, and it is a touch target the moment
+ anybody uses the feature. It also has no background, so the
+ padding out to 44px is invisible. */
.reset-btn {
font-size: var(--yj-text-xs, 11px);
padding: 2px 6px;
@@ -69,7 +80,8 @@ export class ShortcutCapture extends LitElement {
background: transparent;
color: var(--yj-text-tertiary, #888);
cursor: pointer;
- min-width: auto;
+ min-width: 44px;
+ min-height: 44px;
opacity: 0;
transition: opacity 0.15s;
}
diff --git a/frontend/src/components/library-filter/library-filter.ts b/frontend/src/components/library-filter/library-filter.ts
index f62085c..0a5dc13 100644
--- a/frontend/src/components/library-filter/library-filter.ts
+++ b/frontend/src/components/library-filter/library-filter.ts
@@ -23,8 +23,14 @@ export class LibraryFilter extends LitElement {
align-items: center;
}
+ /* 120x32 on the reference device (#186). This control has two
+ placements since #57 -- the desktop top bar and Settings ->
+ Libraries -- and it is the only route to setSelectedLibrary
+ in either, so it is one of the controls #148 argued must not
+ simply be taken away. It is one component, so it reaches the
+ floor in one place. */
select {
- height: 32px;
+ min-height: 44px;
padding: 0 8px;
border-radius: 6px;
border: 1px solid
diff --git a/frontend/src/styles/wa-touch-floor.css.ts b/frontend/src/styles/wa-touch-floor.css.ts
new file mode 100644
index 0000000..385c9fb
--- /dev/null
+++ b/frontend/src/styles/wa-touch-floor.css.ts
@@ -0,0 +1,48 @@
+import { css } from 'lit';
+
+/**
+ * A Web Awesome form control is at least the app's 44px touch floor.
+ *
+ * #56 named 44px and #186 found nothing but the transport had reached
+ * it. Web Awesome's form controls are the part of Settings this app
+ * does not draw: measured on the reference device (TLP301, 424x439),
+ * `wa-input`'s control is **204x20** and `wa-button` **185x21** — the
+ * shortest controls on the page, and the only ones whose height is
+ * decided inside somebody else's shadow root.
+ *
+ * `--wa-form-control-height` is that decision, and it is the library's
+ * own theming variable rather than a part or an internal — the default
+ * theme sets it at `:root` and every control that has a height reads
+ * it (button, input, select, radio). So this is `wa-slider-label`'s
+ * better half: the API first, and no reach into a shadow root at all.
+ *
+ * Three things about it are load-bearing.
+ *
+ * **A custom property inherits through a shadow boundary**, which is
+ * what lets a `:host` declaration reach a `wa-input` the host renders.
+ * That is also why it is a stylesheet a component adopts rather than a
+ * `:root` rule in `index.css`: a `:root` rule would cover every wa
+ * control in the app in one line and be invisible to the component
+ * tier, which renders a component and no page stylesheet. Here the
+ * floor is measurable where it is applied.
+ *
+ * **It is a flat 44px rather than a floor over the library's own
+ * expression.** The default is `round(calc(2 * padding-block + 1em *
+ * line-height), 1px)` — em-based, so `size="small"` is what produced
+ * the 20px above — and a `max(44px, …)` would have to restate that
+ * formula here, which is a copy of somebody else's arithmetic that
+ * goes stale silently. A flat value is safe because this app uses
+ * exactly two sizes, `small` and the default, and both are under the
+ * floor; a `size="large"` added later would be pinned down to 44 and
+ * should take that as the prompt to revisit this.
+ *
+ * **Only the height is pinned.** The font size still comes from
+ * `size="small"`, so a control grows its hit area without growing its
+ * visual weight — which is what #186's Direction asks for and what the
+ * page header's second pass had to be corrected to do.
+ */
+export const waTouchFloor = css`
+ :host {
+ --wa-form-control-height: 44px;
+ }
+`;
diff --git a/frontend/test/components/__screenshots__/page-header.test.ts/page-header-filtered-by-search-chromium-linux.png b/frontend/test/components/__screenshots__/page-header.test.ts/page-header-filtered-by-search-chromium-linux.png
index 16ec379..2a43fb8 100644
Binary files a/frontend/test/components/__screenshots__/page-header.test.ts/page-header-filtered-by-search-chromium-linux.png and b/frontend/test/components/__screenshots__/page-header.test.ts/page-header-filtered-by-search-chromium-linux.png differ
diff --git a/frontend/test/components/__screenshots__/page-header.test.ts/page-header-title-count-and-sort-chromium-linux.png b/frontend/test/components/__screenshots__/page-header.test.ts/page-header-title-count-and-sort-chromium-linux.png
index f0e6892..fb47408 100644
Binary files a/frontend/test/components/__screenshots__/page-header.test.ts/page-header-title-count-and-sort-chromium-linux.png and b/frontend/test/components/__screenshots__/page-header.test.ts/page-header-title-count-and-sort-chromium-linux.png differ
diff --git a/frontend/test/components/settings-touch-targets.test.ts b/frontend/test/components/settings-touch-targets.test.ts
new file mode 100644
index 0000000..efa2e55
--- /dev/null
+++ b/frontend/test/components/settings-touch-targets.test.ts
@@ -0,0 +1,425 @@
+/**
+ * Every control in Settings is at least 44px (#186, second pass).
+ *
+ * The header pass covered the five controls a user meets on every
+ * screen. Settings is the other half and is much the larger one: swept
+ * on the reference device (TLP301, 424x439) with all eleven
+ * `config-section`s expanded, **120 controls** were under the floor,
+ * not the 93 the issue's first table implies, and `config-field` — the
+ * row shape the issue names — is eight of them. The bulk is behind the
+ * disclosures:
+ *
+ * | control | size | count |
+ * |---|---|---|
+ * | `.column-arrow-btn` | **16x14** | 36 |
+ * | `.column-toggle` | 16x16 | 29 |
+ * | `shortcut-capture` button | 80x**25** | 26 |
+ * | download format checkbox | 16x16 | 8 |
+ * | `config-field` select | 335x**30** | 7 |
+ * | `wa-input` / `wa-button` | 204x**20**, 185x**21** | 6 |
+ * | `library-filter` select | 120x**32** | 1 |
+ * | `.overflow-btn` | 31x31 | 1 |
+ *
+ * **This tier can measure it, unlike #187's seek bar**, for the reason
+ * the header pass gives: the controls are real elements and the rules
+ * are min-sizes, so a real Chromium rendering a real component gives
+ * the actual answer at any width. And unlike the header there is no
+ * overflow fit on this page, so nothing here needs the negative-margin
+ * treatment — height is free and the two square controls can simply be
+ * square.
+ *
+ * **What the sweep cannot see is written down here as a test rather
+ * than as a comment**, because it is the trap this whole issue keeps
+ * setting. Two controls are invisible to a walk of `button, select,
+ * input`: `config-field`'s toggle, whose `` is
+ * `opacity: 0; width: 0; height: 0` so the thing a finger hits is the
+ * `` around it (34x19, smaller than anything in either of the
+ * issue's tables), and `shortcut-capture`'s reset button, which renders
+ * only for a shortcut somebody has already rebound. Both are asserted
+ * by name below.
+ */
+import { beforeEach, describe, expect, it } from 'vitest';
+
+import '@components/config-page/config-field';
+import '@components/config-page/config-page';
+import '@components/config-page/download-clients';
+import '@components/config-page/shortcut-capture';
+import '@components/library-filter/library-filter';
+
+import { flush, stub } from '@test/support/harness';
+import { fixture, shadow, shadowAll } from '@test/support/render';
+
+/** The app's touch floor, from #56. */
+const FLOOR = 44;
+
+/**
+ * Everything a finger can hit, through every shadow root under `root`.
+ *
+ * It descends rather than querying one root because Settings is a tree
+ * of components — `config-page` renders `config-section`s holding
+ * `config-field`s and `shortcut-capture`s — and the defect was
+ * distributed across all of them. This is the device sweep, run here.
+ */
+function controlsUnder(root: Document | ShadowRoot | Element): { name: string; el: HTMLElement }[] {
+ const SELECTOR = 'button, select, input, [role="button"], [role="tab"], [role="switch"]';
+ const found: { name: string; el: HTMLElement }[] = [];
+ const seen = new Set();
+
+ const walk = (node: ParentNode, depth: number): void => {
+ if (depth > 20) return;
+
+ for (const el of Array.from(node.querySelectorAll('*'))) {
+ if (el.matches(SELECTOR) && !seen.has(el)) {
+ seen.add(el);
+
+ const box = el.getBoundingClientRect();
+ const style = getComputedStyle(el);
+ const rendered =
+ (box.width > 0 || box.height > 0) &&
+ style.visibility !== 'hidden' &&
+ style.display !== 'none';
+
+ if (rendered) {
+ const host = (el.getRootNode() as ShadowRoot).host;
+
+ found.push({
+ name: `${host ? host.tagName.toLowerCase() : 'root'} ${
+ (typeof el.className === 'string' && el.className) || el.tagName.toLowerCase()
+ }`,
+ el: el as HTMLElement,
+ });
+ }
+ }
+
+ if (el.shadowRoot) walk(el.shadowRoot, depth + 1);
+ }
+ };
+
+ walk(root as ParentNode, 0);
+
+ return found;
+}
+
+/**
+ * What a finger actually hits for `el`.
+ *
+ * For everything in this app that is one element, that is the element.
+ * A native checkbox is the exception and is why this function exists:
+ * it cannot grow its hit area without growing its paint, and a 44px
+ * checkbox is not what anyone wants — so a checkbox that has a label
+ * is targeted *through* the label, which is the fix the column lists
+ * and the download formats both use.
+ *
+ * The fallback is the checkbox itself, deliberately: a checkbox with
+ * no label is a 16px target and this must still say so.
+ */
+function hitTarget(el: HTMLElement): HTMLElement {
+ const input = el as HTMLInputElement;
+
+ if (input.type !== 'checkbox' && input.type !== 'radio') return el;
+
+ const wrapping = el.closest('label');
+ const root = el.getRootNode() as ShadowRoot | Document;
+ const associated = input.id
+ ? root.querySelector(`label[for="${CSS.escape(input.id)}"]`)
+ : null;
+
+ return wrapping ?? associated ?? el;
+}
+
+/** The ones that miss the floor, reported with the numbers. */
+function tooSmall(controls: { name: string; el: HTMLElement }[]): string[] {
+ return controls
+ .map(({ name, el }) => {
+ const box = hitTarget(el).getBoundingClientRect();
+
+ return { name, w: Math.round(box.width), h: Math.round(box.height) };
+ })
+ .filter((c) => c.w < FLOOR || c.h < FLOOR)
+ .map((c) => `${c.name} ${c.w}x${c.h}`);
+}
+
+/**
+ * Open every disclosure under `host`, so the sweep can see the page.
+ *
+ * A collapsed `config-section` renders its body with `hidden`, so its
+ * controls measure 0x0 — which is exactly why the issue's first table
+ * lists seven Settings controls and the real count is 120.
+ */
+async function expandEverySection(host: HTMLElement & { updateComplete: Promise }) {
+ const sections = shadowAll(host, 'config-section');
+
+ expect(sections.length, 'the page renders disclosures to open').toBeGreaterThan(0);
+
+ for (const section of sections) {
+ section.shadowRoot
+ ?.querySelector('button[aria-expanded="false"]')
+ ?.click();
+ }
+
+ await flush();
+ await host.updateComplete;
+
+ for (const section of sections) {
+ await (section as HTMLElement & { updateComplete?: Promise }).updateComplete;
+ }
+
+ return sections;
+}
+
+/** A control's own box, named so a failure says which and how small. */
+function boxOf(el: Element | null | undefined): string {
+ if (!el) return 'missing';
+
+ const box = el.getBoundingClientRect();
+
+ return `${Math.round(box.width)}x${Math.round(box.height)}`;
+}
+
+function meetsFloor(el: Element | null | undefined): boolean {
+ if (!el) return false;
+
+ const box = el.getBoundingClientRect();
+
+ return Math.round(box.width) >= FLOOR && Math.round(box.height) >= FLOOR;
+}
+
+describe('a config field is the shape every Settings row uses', () => {
+ it.each(['text', 'number', 'select', 'directory', 'color'] as const)(
+ 'a %s field meets the floor',
+ async (type) => {
+ const el = await fixture('config-field', {
+ schema: {
+ key: 'k',
+ label: 'Music folder',
+ type,
+ options: [{ value: 'dark', label: 'Dark' }],
+ },
+ value: type === 'color' ? '#ffd43b' : '',
+ });
+
+ const controls = controlsUnder(el.shadowRoot!);
+
+ // A sweep that found nothing passes vacuously.
+ expect(controls.length).toBeGreaterThan(0);
+ expect(tooSmall(controls)).toEqual([]);
+ },
+ );
+
+ it('grows the toggle, which no sweep of inputs can see', async () => {
+ // The `` is opacity: 0; width: 0; height: 0, so the walk
+ // above skips it as a zero-sized node -- and the thing a finger
+ // hits is the styling around it, which measured 34x19 on
+ // the device. It is absent from #186's tables for exactly that
+ // reason, and it is smaller than everything in them.
+ const el = await fixture('config-field', {
+ schema: { key: 'x', label: 'Scan on startup', type: 'toggle' },
+ value: true,
+ });
+
+ const target = shadow(el, '.toggle-switch');
+
+ expect(boxOf(target)).toBe('44x44');
+ });
+
+ it('keeps the toggle painted at its old size, in its old place', async () => {
+ // A 44px pill is not what a switch should look like. The box is
+ // 44px and the paint is not: the slider is a child centred in it,
+ // and negative inline margins hand the extra width back so the
+ // pill stays flush with the inputs in the rows above.
+ const el = await fixture('config-field', {
+ schema: { key: 'x', label: 'Scan on startup', type: 'toggle' },
+ value: true,
+ });
+
+ const target = shadow(el, '.toggle-switch') as HTMLElement;
+ const slider = shadow(el, '.toggle-slider');
+
+ expect(slider!.getBoundingClientRect().height).toBeLessThan(FLOOR);
+
+ const style = getComputedStyle(target);
+ const handedBack =
+ parseFloat(style.marginInlineStart) + parseFloat(style.marginInlineEnd);
+
+ expect(handedBack).toBeLessThan(0);
+ });
+});
+
+describe('the shortcut editor', () => {
+ it('meets the floor', async () => {
+ const el = await fixture('shortcut-capture', {
+ action: 'play.toggle',
+ label: 'Play/pause',
+ currentKey: 'Space',
+ defaultKey: 'Space',
+ });
+
+ expect(meetsFloor(shadow(el, 'button'))).toBe(true);
+ });
+
+ it('grows the reset button, which only a rebound shortcut renders', async () => {
+ // Not in either of #186's tables, and it cannot be: a sweep of a
+ // freshly-installed app never sees it. It appears the moment
+ // anybody uses the feature.
+ const el = await fixture('shortcut-capture', {
+ action: 'play.toggle',
+ label: 'Play/pause',
+ currentKey: 'K',
+ defaultKey: 'Space',
+ });
+
+ const reset = shadow(el, '.reset-btn');
+
+ expect(reset, 'a rebound shortcut renders a reset button').toBeTruthy();
+ expect(meetsFloor(reset)).toBe(true);
+ });
+});
+
+describe('the library filter', () => {
+ it('meets the floor in both of its placements', async () => {
+ // One component, two mount points since #57 -- the desktop top bar
+ // and Settings -> Libraries -- so it reaches the floor once.
+ const el = await fixture('library-filter');
+
+ const select = shadow(el, 'select');
+
+ expect(select, 'the filter renders a select').toBeTruthy();
+ expect(Math.round(select!.getBoundingClientRect().height)).toBeGreaterThanOrEqual(FLOOR);
+ });
+});
+
+describe('download clients', () => {
+ beforeEach(() => {
+ stub('download.Service.ListProviders', []);
+ stub('download.Service.ProviderKinds', []);
+ stub('config.Config.GetDownloadPreferences', {});
+ });
+
+ it('gives Web Awesome form controls the floor through the library API', async () => {
+ // wa-input's control is inside somebody else's shadow root, so the
+ // height comes from --wa-form-control-height rather than from a
+ // rule of ours reaching in. A custom property inherits through a
+ // shadow boundary, which is what makes a :host declaration reach
+ // it -- and what makes it measurable here.
+ const el = await fixture('download-clients');
+
+ await flush();
+ await expandEverySection(el);
+
+ expect(getComputedStyle(el).getPropertyValue('--wa-form-control-height').trim()).toBe(
+ '44px',
+ );
+
+ // And the outcome, not only the mechanism. A sweep of `input`
+ // reports a wa-input at 204x**42** even when this is right,
+ // because the inner input sits *inside* the control's own 1px
+ // border -- Web Awesome sizes it
+ // `calc(--wa-form-control-height - border-width * 2)`. What a
+ // finger hits is `part=base`, measured at 238x44 on the device.
+ //
+ // This reaches into another library's shadow root, which
+ // `name-dialog.ts` only permits where the failure is bounded. It
+ // is bounded the other way here: this is a test, so a renamed
+ // part fails loudly rather than silently passing, which is the
+ // direction that costs nobody a device session.
+ const input = shadowAll(el, 'wa-input').find(
+ (w) => w.getBoundingClientRect().height > 0,
+ );
+
+ expect(input, 'the add form renders a wa-input').toBeTruthy();
+
+ const base = input!.shadowRoot?.querySelector('[part~="base"]');
+
+ expect(base, 'wa-input still calls its control box "base"').toBeTruthy();
+ expect(Math.round(base!.getBoundingClientRect().height)).toBeGreaterThanOrEqual(FLOOR);
+ });
+
+ it('makes each allowed-format checkbox label a target', async () => {
+ const el = await fixture('download-clients');
+
+ await flush();
+ await el.updateComplete;
+
+ // Every section starts collapsed, and a collapsed body is `hidden`
+ // — so its controls measure 0x0 and a sweep of an unexpanded page
+ // reports them all as fine. That is how the issue's first table
+ // came to list seven Settings controls when there are 120.
+ await expandEverySection(el);
+
+ const options = shadowAll(el, '.format-option');
+
+ expect(options.length).toBeGreaterThan(0);
+
+ const short = options
+ .map((o) => ({ label: o.textContent?.trim(), h: Math.round(o.getBoundingClientRect().height) }))
+ .filter((o) => o.h < FLOOR);
+
+ expect(short).toEqual([]);
+ });
+});
+
+describe('the whole Settings page', () => {
+ beforeEach(() => {
+ for (const path of [
+ 'library.Library.GetAllLibrariesWithTrackCounts',
+ 'jobs.Service.GetJobs',
+ 'download.Service.ListProviders',
+ 'download.Service.ProviderKinds',
+ ]) {
+ stub(path, []);
+ }
+
+ stub('config.Config.GetShortcuts', {});
+ stub('config.Config.GetDownloadPreferences', {});
+ stub('config.Config.GetThemeAccentColor', '#ffd43b');
+ stub('config.Config.GetThemeBackgroundShade', 'dark');
+ });
+
+ it('has no control under the floor with every section expanded', async () => {
+ // The device sweep, run here: eleven collapsed sections is what
+ // made the first table look like seven controls. The density is
+ // behind the disclosures.
+ const el = await fixture('config-page');
+
+ await flush();
+ await el.updateComplete;
+ await expandEverySection(el);
+
+ const controls = controlsUnder(el.shadowRoot!);
+
+ expect(controls.length).toBeGreaterThan(0);
+ expect(tooSmall(controls)).toEqual([]);
+ });
+
+ it('makes a column row a target by naming it, not by growing the checkbox', async () => {
+ // A native checkbox cannot grow its hit area without growing its
+ // paint. The label is the target instead -- which is also the
+ // argument config-field already makes for its own labels, and it
+ // is behaviour rather than annotation: the column's name is now a
+ // click target for its checkbox.
+ const el = await fixture('config-page');
+
+ await flush();
+ await el.updateComplete;
+ await expandEverySection(el);
+
+ const labels = shadowAll(el, 'label.column-label');
+
+ expect(labels.length).toBeGreaterThan(0);
+
+ for (const label of labels) {
+ const target = label.htmlFor
+ ? el.shadowRoot!.getElementById(label.htmlFor)
+ : null;
+
+ expect(
+ (target as HTMLInputElement | null)?.type,
+ `${label.textContent?.trim()} names its checkbox`,
+ ).toBe('checkbox');
+ expect(
+ Math.round(label.getBoundingClientRect().height),
+ `${label.textContent?.trim()} is a target`,
+ ).toBeGreaterThanOrEqual(FLOOR);
+ }
+ });
+});