refactor(download): rename Want/Request to Request/Download, unify downloads flow, add auto-download guardrails

The durable "I asked for this" record was called Want, and the one-shot search-and-grab attempt was called Request — names that didn't match what either actually did. Want is now Request, and the old Request/Item is now Download/DownloadItem, with a table-rename migration (download_wants -> download_requests, old download_requests -> download_downloads) safe against both fresh installs and existing data. Every anchored manual download now upserts/reuses a durable Request before running, so a "download now" that finds nothing is picked up by the background reconciler automatically instead of just failing with no trace — the gap that caused this session's repeated "no candidates found" failures on the same album. Also adds auto-download guardrails (file-size min/max with a preferred target, allowed file types) that gate what the pipeline may grab unattended, live-editable from a new settings section. The frontend's wanted-view becomes downloads-view, with a new Downloads tab showing attempt/transfer history that previously had no UI at all. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2Agd9af5hE7qzti2ackiS
2026-08-10 14:35:57 -04:00
parent cbd82a5a74
commit 65333857e2
62 changed files with 4067 additions and 2524 deletions
@@ -0,0 +1,53 @@
+-- One row per "go find me this", from the moment a search is fired
+-- until the files are in the library or the attempt is abandoned.  A
+-- Download is one attempt: it searches, it grabs, it succeeds or
+-- fails, and then it is history.  See download_requests.sql for the
+-- durable record a Download may be attached to.
+--
+-- release_mbid / release_group_mbid are the anchor: a download that
+-- carries one can be matched against a known tracklist at import time,
+-- which is what makes unattended completion safe.  Free-text downloads
+-- (both NULL) are always presented to the user for confirmation.
+--
+-- `expected` caches the anchor's tracklist as JSON so ranking and
+-- import do not have to re-resolve it, and so a download survives the
+-- explore index being rebuilt underneath it.
+
+
+CREATE TABLE IF NOT EXISTS download_downloads (
+    id                 TEXT PRIMARY KEY,
+    library_id         INTEGER NOT NULL,
+    -- source records where the download came from: 'explore-album',
+    -- 'explore-artist', 'missing-album', 'wanted', 'manual'.
+    source             TEXT    NOT NULL DEFAULT 'manual',
+    -- request_id is set when this download is attached to a durable
+    -- Request (see download_requests.sql), whether raised by the
+    -- reconciler or attached to a manual anchored download.  NULL for
+    -- a free-text download with nothing stable to attach to.
+    -- Requests are durable and downloads are disposable, so the delete
+    -- is a SET NULL rather than a cascade in either direction.
+    request_id         INTEGER REFERENCES download_requests(id) ON DELETE SET NULL,
+    release_mbid       TEXT,
+    release_group_mbid TEXT,
+    -- recording_mbid anchors a single-track download raised from a
+    -- track-level request.
+    recording_mbid     TEXT,
+    artist             TEXT    NOT NULL DEFAULT '',
+    album              TEXT    NOT NULL DEFAULT '',
+    query              TEXT    NOT NULL DEFAULT '',
+    expected           TEXT    NOT NULL DEFAULT '[]',
+    state              TEXT    NOT NULL DEFAULT 'searching'
+        CHECK(state IN ('searching', 'found', 'queued', 'grabbing',
+                        'verifying', 'tagging', 'importing',
+                        'complete', 'cancelled', 'failed')),
+    error              TEXT    NOT NULL DEFAULT '',
+    created_at         DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    updated_at         DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
+    FOREIGN KEY(library_id) REFERENCES libraries(id) ON DELETE CASCADE
+);
+
+CREATE INDEX IF NOT EXISTS idx_download_downloads_created
+    ON download_downloads(created_at DESC);
+
+CREATE INDEX IF NOT EXISTS idx_download_downloads_state
+    ON download_downloads(state);