From 42d3f45d85afa694e9545997af3ff4ac814ad021 Mon Sep 17 00:00:00 2001 From: Logan Jones Date: Sun, 15 Feb 2026 12:52:46 -0600 Subject: [PATCH] fix(ci): remove build-check job from CI workflow (#66) * ci: remove build-check job from CI workflow The cross-platform build verification is redundant in CI since the build and release pipeline (build.yml) already performs full builds on every release. This reduces CI runner time and costs. * ci: restrict build-check to Linux PRs and pin R2 action to v1.4 - Build-check now only runs on pull requests (skipped on main merge) with only Linux/amd64 enabled; macOS and Windows are commented out since the Build & Publish workflow handles all platforms on release. - Pin ryand56/r2-upload-action from floating v1 tag to v1.4 to fix the upload failure seen in the v1.1.0 release build. --- .github/workflows/build.yml | 2 +- .github/workflows/ci.yml | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 099ed80..ed3fe5e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -176,7 +176,7 @@ jobs: artifacts/release/yellowjacket-windows-amd64.exe - name: Upload to R2 - uses: ryand56/r2-upload-action@v1 + uses: ryand56/r2-upload-action@v1.4 with: r2-account-id: ${{ secrets.R2_ACCOUNT_ID }} r2-access-key-id: ${{ secrets.R2_ACCESS_KEY_ID }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5dbbc17..b2a4062 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -141,8 +141,6 @@ jobs: # ────────────────────────────────────────────── # Frontend: type-check - # (full build is verified by the build-check job - # via Wails which handles path resolution) # ────────────────────────────────────────────── frontend: name: Frontend Type Check @@ -170,11 +168,13 @@ jobs: run: pnpm exec tsc --noEmit # ────────────────────────────────────────────── - # Build verification: ensure it compiles on all - # target platforms (no artifacts uploaded) + # Build verification: ensure it compiles + # (only runs on PRs; release builds are handled + # by the Build & Publish workflow) # ────────────────────────────────────────────── build-check: name: Build Check (${{ matrix.platform }}) + if: github.event_name == 'pull_request' needs: [go-checks, go-test, codegen-check, frontend] strategy: fail-fast: false @@ -184,12 +184,12 @@ jobs: os: ubuntu-latest build-name: yellowjacket apt-deps: libasound2-dev - - platform: darwin/universal - os: macos-latest - build-name: yellowjacket - - platform: windows/amd64 - os: windows-latest - build-name: yellowjacket.exe + # - platform: darwin/universal + # os: macos-latest + # build-name: yellowjacket + # - platform: windows/amd64 + # os: windows-latest + # build-name: yellowjacket.exe runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v6