perf: batch popularity lookups in single SQLite query (100+ → 1)

boostWithIndexPopularity was calling GetPopularity() and IsInLibrary()
individually for every search result — ~100 separate SQLite queries
for a typical search (20 artists × 2 + 20 RGs × 2 + 20 recordings).
This took 7.5s on the 'fast path' that was supposed to take ~5ms.

Added GetPopularityBatch(mbids) — collects all MBIDs across all
entity types and fetches popularity + in_library in a single
SELECT ... WHERE mbid IN (...) query. The library bonus (+10M) is
applied during the batch scan.

Expected Phase 2 improvement: ~7.5s → <10ms.
This commit is contained in:
2026-03-29 23:55:26 -04:00
parent 8a138797dd
commit 3d0349a427
2 changed files with 77 additions and 21 deletions
+47
View File
@@ -316,6 +316,53 @@ func (si *SearchIndex) GetPopularity(mbid string) int {
return 0
}
// GetPopularityBatch returns popularity (listen count) for multiple
// MBIDs in a single query. Returns a map of MBID → popularity.
func (si *SearchIndex) GetPopularityBatch(mbids []string) map[string]int {
if len(mbids) == 0 {
return nil
}
placeholders := make([]string, len(mbids))
args := make([]any, len(mbids))
for i, m := range mbids {
placeholders[i] = "?"
args[i] = m
}
query := "SELECT mbid, popularity, in_library FROM explore_index WHERE mbid IN (" +
strings.Join(placeholders, ",") + ")"
rows, err := si.db.QueryContext(query, args...)
if err != nil {
return nil
}
defer func() { _ = rows.Close() }()
result := make(map[string]int, len(mbids))
for rows.Next() {
var mbid string
var pop int
var inLib int
if err := rows.Scan(&mbid, &pop, &inLib); err == nil {
existing, ok := result[mbid]
if !ok || pop > existing {
if inLib == 1 {
pop += 10_000_000 //nolint:mnd // library bonus
}
result[mbid] = pop
}
}
}
return result
}
// IsInLibrary returns whether the given MBID is marked as in the
// user's local library in the search index.
func (si *SearchIndex) IsInLibrary(mbid string) bool {