fix: resolve all lint errors and make linting a required CI check (#62)
- Fix 10 err113 violations: extract dynamic errors to package-level sentinels - Fix 12 errcheck violations: handle unchecked error returns in player, metadata, and config packages - Fix 4 revive stutter warnings: rename player.PlayerState to player.State, player.PlayerVolume to player.Volume, queue.QueueTrack to queue.Track, queue.QueueState to queue.State - Fix 2 staticcheck SA4001: simplify *&x to x in assets handler - Fix 5 unused constants: remove dead AudioFileType iota block in models - Fix gci/gofumpt/wsl formatting issues across multiple files - Add gofumpt module-path setting to .golangci.yml for correct import grouping - Fix player test: gate integration test behind YELLOWJACKET_INTEGRATION env var instead of only skipping in CI, and replace t.Errorf+t.Failed with t.Fatalf - Remove continue-on-error from golangci-lint CI step so linting is now required
This commit is contained in:
@@ -7,6 +7,12 @@ import (
|
||||
"strconv"
|
||||
)
|
||||
|
||||
// Sentinel errors for library queries.
|
||||
var (
|
||||
errNoTracksInLibrary = errors.New("no tracks in library")
|
||||
errNoTracksForAlbum = errors.New("no tracks found for album")
|
||||
)
|
||||
|
||||
// Track represents a playable audio file in the library.
|
||||
type Track struct {
|
||||
TrackName string
|
||||
@@ -38,7 +44,7 @@ func (l *Library) GetAllTracks() ([]Track, error) {
|
||||
if len(audioFiles) == 0 {
|
||||
l.logger.Error("no tracks in library")
|
||||
|
||||
return nil, errors.New("no tracks in library")
|
||||
return nil, errNoTracksInLibrary
|
||||
}
|
||||
|
||||
var formattedTracks []Track
|
||||
@@ -68,7 +74,7 @@ func (l *Library) GetAlbumTracks(albumID int64) ([]Track, error) {
|
||||
}
|
||||
|
||||
if len(rows) == 0 {
|
||||
return nil, fmt.Errorf("no tracks found for album %d", albumID)
|
||||
return nil, fmt.Errorf("%w %d", errNoTracksForAlbum, albumID)
|
||||
}
|
||||
|
||||
tracks := make([]Track, 0, len(rows))
|
||||
|
||||
Reference in New Issue
Block a user