fix: resolve all lint errors and make linting a required CI check (#62)

- Fix 10 err113 violations: extract dynamic errors to package-level sentinels
- Fix 12 errcheck violations: handle unchecked error returns in player,
  metadata, and config packages
- Fix 4 revive stutter warnings: rename player.PlayerState to player.State,
  player.PlayerVolume to player.Volume, queue.QueueTrack to queue.Track,
  queue.QueueState to queue.State
- Fix 2 staticcheck SA4001: simplify *&x to x in assets handler
- Fix 5 unused constants: remove dead AudioFileType iota block in models
- Fix gci/gofumpt/wsl formatting issues across multiple files
- Add gofumpt module-path setting to .golangci.yml for correct import grouping
- Fix player test: gate integration test behind YELLOWJACKET_INTEGRATION env var
  instead of only skipping in CI, and replace t.Errorf+t.Failed with t.Fatalf
- Remove continue-on-error from golangci-lint CI step so linting is now required

This commit is contained in:

logan

2026-02-14 01:52:27 -06:00

committed by

GitHub

parent 2d6e22105d

commit 30b2480df4

16 changed files with 159 additions and 98 deletions

									
										.golangci.yml
									
		+2
		
												View File
												
				@@ -42,3 +42,5 @@ formatters:

				        - standard

				        - default

				        - prefix(yellowjacket)

				    gofumpt:

				      module-path: yellowjacket