feat(a11y): give the context menu a keyboard, and the app a voice
The context menu was the only route to Play, Add to Queue, Play Next, Add to Playlist, Favourite and Track Details, and it opened on right-click alone: the panel had no role=menu, so its six menuitems were orphaned, nothing moved focus into it, and nothing handled arrows or Escape (a11y.3). Phase 1 deferred this deliberately so it would land with the dialogs, as one focus-management implementation. MenuKeyboard is that model. It is standalone rather than part of ContextMenuController because playlist-view renders a menu without the controller, and the only thing worse than a menu with no keyboard model is two menus with two of them. Shift+F10 and the ContextMenu key open it from a focused row, anchored to that row, and focus returns there. Three lists had no focused row to open it from, so they gained a roving tab stop (utils/roving-rows.ts, written once rather than three times). track-list keeps its own: it predates this, carries selection semantics the other three do not have, and is pinned by its own tests. Also the ARIA tail this is one story with: aria-sort on the column headers (role=columnheader arrived in Phase 1 without it), listbox and option on the four selectable grids — aria-selected on role=button is invalid and was being dropped, so the state the whole ctrl/shift interaction exists to produce was invisible — and live regions on the four async surfaces that changed in silence. Two things a reproduction taught that reading could not: the wa-dropdown-items have not set their role when the host's updateComplete resolves, so querying by role then finds nothing and the menu opens without taking focus; and focus() on a popup that has not positioned itself is a silent no-op.
This commit is contained in:
@@ -24,6 +24,7 @@ import { queueStore } from '@store/queue-store';
|
||||
import {
|
||||
ContextMenuController,
|
||||
contextMenuStyles,
|
||||
isContextMenuKey,
|
||||
} from '@utils/context-menu-controller.js';
|
||||
import type { ContextMenuHost } from '@utils/context-menu-controller.js';
|
||||
import { FavoritesController } from '@store/controllers/favorites-controller';
|
||||
@@ -948,6 +949,23 @@ export class ArtistsView
|
||||
);
|
||||
};
|
||||
|
||||
/** Shift+F10 / ContextMenu on a focused card, anchored to the card
|
||||
* so the menu appears where the artist is and focus goes back
|
||||
* there when it closes. */
|
||||
private openArtistMenuFromKey(
|
||||
e: KeyboardEvent,
|
||||
artist: library.Artist,
|
||||
): void {
|
||||
const card = e.currentTarget as HTMLElement | null;
|
||||
|
||||
if (!card) return;
|
||||
|
||||
e.preventDefault();
|
||||
e.stopPropagation();
|
||||
this.contextMenuArtistId = artist.ID;
|
||||
this.ctxMenu.openFrom(card);
|
||||
}
|
||||
|
||||
private async onContextMenuAction(
|
||||
action: string,
|
||||
) {
|
||||
@@ -1193,7 +1211,7 @@ export class ArtistsView
|
||||
data-index=${index}
|
||||
tabindex=${this.roving.tabIndexFor(index)}
|
||||
@focus=${() => this.roving.noteFocus(index)}
|
||||
role="button"
|
||||
role="option"
|
||||
aria-label="${artist.Name}"
|
||||
aria-selected="${isSelected}"
|
||||
style="
|
||||
@@ -1212,6 +1230,15 @@ export class ArtistsView
|
||||
artist,
|
||||
)}
|
||||
@keydown=${(e: KeyboardEvent) => {
|
||||
if (isContextMenuKey(e)) {
|
||||
this.openArtistMenuFromKey(
|
||||
e,
|
||||
artist,
|
||||
);
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
if (
|
||||
e.key === 'Enter' ||
|
||||
e.key === ' '
|
||||
@@ -1266,6 +1293,8 @@ export class ArtistsView
|
||||
? html`
|
||||
<div
|
||||
class="context-menu-panel"
|
||||
role="menu"
|
||||
aria-label="Artist actions"
|
||||
>
|
||||
<wa-dropdown-item
|
||||
@click=${() =>
|
||||
@@ -1442,6 +1471,9 @@ export class ArtistsView
|
||||
@keydown=${this.roving.handleKeydown}
|
||||
>
|
||||
<lit-virtualizer
|
||||
role="listbox"
|
||||
aria-label="Artists"
|
||||
aria-multiselectable="true"
|
||||
.items=${entries}
|
||||
.renderItem=${(entry: ArtistEntry) => this.renderArtistCard(entry)}
|
||||
.keyFunction=${(entry: ArtistEntry) => entry.artist.ID}
|
||||
|
||||
Reference in New Issue
Block a user